feat(webhook-trigger-events): Echter Webhook-Send bei TimeEntry-Create/Update/Delete [tsc:fail]
This commit is contained in:
parent
d7a4c1ff85
commit
d8bb1b2c38
@ -1,5 +1,8 @@
|
|||||||
{
|
{
|
||||||
"completed_features": [],
|
"completed_features": [],
|
||||||
"current_feature": "saved-views",
|
"current_feature": "webhook-trigger-events",
|
||||||
"started_at": "2026-05-23T06:57:51.069062"
|
"started_at": "2026-05-23T06:57:51.069062",
|
||||||
|
"attempted_features": [
|
||||||
|
"saved-views"
|
||||||
|
]
|
||||||
}
|
}
|
||||||
@ -1776,3 +1776,22 @@ src/index.ts(27,25): error TS2769: No overload matches this call.
|
|||||||
Overload 2 of 3, '(plugin: FastifyPluginAsync<{ limits: { fileSize: number; }; }, RawServerDefault, FastifyTypeProvider, FastifyBaseLogger>, opts?: FastifyRegisterOptions<...> | undefined): FastifyInstance<...> & PromiseLike<...>', gave the following error.
|
Overload 2 of 3, '(plugin: FastifyPluginAsync<{ limits: { fileSize: number; }; }, RawServerDefault, FastifyTypeProvider, FastifyBaseLogger>, opts?: FastifyRegisterOptions<...> | undefined): FastifyInstance<...> & PromiseLike<...>', gave the following error.
|
||||||
Argument of type 'Promise<FastifyMultipartPlugin>' is not assignable to parameter of type 'FastifyPluginAsync<{ limits: { fileSize: number; }; }, RawServerDefault, FastifyTypeProvider, FastifyBaseLogger>'.
|
Argument of type 'Promise<FastifyMultipartPlugin>' is not assignable to parameter of type 'FastifyPluginAsync<{ limits: { fileSize: number; }; }, RawServerDefault, FastifyTypeProvider, FastifyBaseLogger>'.
|
||||||
Type 'Promise<FastifyMultipartPlugin>' provides no match for the signature '(instance: FastifyInstance<RawServerDefault, IncomingMessage, ServerResponse<IncomingMessage>, FastifyBaseLogger, FastifyTy
|
Type 'Promise<FastifyMultipartPlugin>' provides no match for the signature '(instance: FastifyInstance<RawServerDefault, IncomingMessage, ServerResponse<IncomingMessage>, FastifyBaseLogger, FastifyTy
|
||||||
|
- `07:00:45` **INFO** Committed feature saved-views
|
||||||
|
- `07:00:46` **INFO** Pushed: rc=0
|
||||||
|
|
||||||
|
## Phase-3 Feature: webhook-trigger-events (2026-05-23 07:00:46)
|
||||||
|
|
||||||
|
- `07:00:46` **INFO** Description: Echter Webhook-Send bei TimeEntry-Create/Update/Delete
|
||||||
|
- `07:00:46` **INFO** Generating apps/api/src/services/webhooks.ts (WebhookDispatcher class. Methode triggerEvent(event: string, payload: …)
|
||||||
|
- `07:00:55` **INFO** wrote 1266 chars in 9.7s (attempt 1)
|
||||||
|
- `07:00:55` **INFO** Generating apps/api/src/routes/time-entries.ts (ERWEITERT — behalte alles. Nach insert/update/delete jeweils webhookDi…)
|
||||||
|
- `07:02:05` **INFO** wrote 7753 chars in 70.1s (attempt 1)
|
||||||
|
- `07:02:05` **INFO** Running tsc --noEmit on api…
|
||||||
|
- `07:02:07` **WARN** tsc errors:
|
||||||
|
src/index.ts(27,25): error TS2769: No overload matches this call.
|
||||||
|
Overload 1 of 3, '(plugin: FastifyPluginCallback<{ limits: { fileSize: number; }; }, RawServerDefault, FastifyTypeProvider, FastifyBaseLogger>, opts?: FastifyRegisterOptions<...> | undefined): FastifyInstance<...> & PromiseLike<...>', gave the following error.
|
||||||
|
Argument of type 'Promise<FastifyMultipartPlugin>' is not assignable to parameter of type 'FastifyPluginCallback<{ limits: { fileSize: number; }; }, RawServerDefault, FastifyTypeProvider, FastifyBaseLogger>'.
|
||||||
|
Type 'Promise<FastifyMultipartPlugin>' provides no match for the signature '(instance: FastifyInstance<RawServerDefault, IncomingMessage, ServerResponse<IncomingMessage>, FastifyBaseLogger, FastifyTypeProvider>, opts: { ...; }, done: (err?: Error | undefined) => void): void'.
|
||||||
|
Overload 2 of 3, '(plugin: FastifyPluginAsync<{ limits: { fileSize: number; }; }, RawServerDefault, FastifyTypeProvider, FastifyBaseLogger>, opts?: FastifyRegisterOptions<...> | undefined): FastifyInstance<...> & PromiseLike<...>', gave the following error.
|
||||||
|
Argument of type 'Promise<FastifyMultipartPlugin>' is not assignable to parameter of type 'FastifyPluginAsync<{ limits: { fileSize: number; }; }, RawServerDefault, FastifyTypeProvider, FastifyBaseLogger>'.
|
||||||
|
Type 'Promise<FastifyMultipartPlugin>' provides no match for the signature '(instance: FastifyInstance<RawServerDefault, IncomingMessage, ServerResponse<IncomingMessage>, FastifyBaseLogger, FastifyTy
|
||||||
|
|||||||
@ -3,6 +3,7 @@ import { db } from "../db"
|
|||||||
import { timeEntries, timeEntryAttachments } from "../db/schema"
|
import { timeEntries, timeEntryAttachments } from "../db/schema"
|
||||||
import { eq, and, gte, lte, isNull, inArray } from "drizzle-orm"
|
import { eq, and, gte, lte, isNull, inArray } from "drizzle-orm"
|
||||||
import { z } from "zod"
|
import { z } from "zod"
|
||||||
|
import { webhookDispatcher } from "../webhooks"
|
||||||
|
|
||||||
const TimeEntrySchema = z.object({
|
const TimeEntrySchema = z.object({
|
||||||
projectId: z.string().uuid().optional(),
|
projectId: z.string().uuid().optional(),
|
||||||
@ -119,6 +120,7 @@ export default async function timeEntryRoutes(fastify: FastifyInstance) {
|
|||||||
})
|
})
|
||||||
.returning()
|
.returning()
|
||||||
|
|
||||||
|
await webhookDispatcher.triggerEvent('time_entry.created', entry)
|
||||||
return reply.code(201).send(entry)
|
return reply.code(201).send(entry)
|
||||||
})
|
})
|
||||||
|
|
||||||
@ -136,6 +138,7 @@ export default async function timeEntryRoutes(fastify: FastifyInstance) {
|
|||||||
})
|
})
|
||||||
.returning()
|
.returning()
|
||||||
|
|
||||||
|
await webhookDispatcher.triggerEvent('time_entry.created', entry)
|
||||||
return reply.code(201).send(entry)
|
return reply.code(201).send(entry)
|
||||||
})
|
})
|
||||||
|
|
||||||
@ -164,6 +167,7 @@ export default async function timeEntryRoutes(fastify: FastifyInstance) {
|
|||||||
.where(eq(timeEntries.id, id))
|
.where(eq(timeEntries.id, id))
|
||||||
.returning()
|
.returning()
|
||||||
|
|
||||||
|
await webhookDispatcher.triggerEvent('time_entry.updated', updated)
|
||||||
return updated
|
return updated
|
||||||
})
|
})
|
||||||
|
|
||||||
@ -197,6 +201,7 @@ export default async function timeEntryRoutes(fastify: FastifyInstance) {
|
|||||||
.where(eq(timeEntries.id, id))
|
.where(eq(timeEntries.id, id))
|
||||||
.returning()
|
.returning()
|
||||||
|
|
||||||
|
await webhookDispatcher.triggerEvent('time_entry.updated', updated)
|
||||||
return updated
|
return updated
|
||||||
})
|
})
|
||||||
|
|
||||||
@ -220,13 +225,37 @@ export default async function timeEntryRoutes(fastify: FastifyInstance) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
await db.delete(timeEntries).where(eq(timeEntries.id, id))
|
await db.delete(timeEntries).where(eq(timeEntries.id, id))
|
||||||
|
await webhookDispatcher.triggerEvent('time_entry.deleted', entry)
|
||||||
|
return reply.code(204).send()
|
||||||
|
})
|
||||||
|
|
||||||
|
fastify.delete("/bulk", async (request, reply) => {
|
||||||
|
const user = request.user as { sub: string; role: string }
|
||||||
|
const { ids } = BulkDeleteSchema.parse(request.body)
|
||||||
|
|
||||||
|
const deletedEntries = await db
|
||||||
|
.select()
|
||||||
|
.from(timeEntries)
|
||||||
|
.where(
|
||||||
|
and(
|
||||||
|
inArray(timeEntries.id, ids),
|
||||||
|
user.role === "admin" ? undefined : eq(timeEntries.userId, user.sub)
|
||||||
|
)
|
||||||
|
)
|
||||||
|
|
||||||
|
await db.delete(timeEntries).where(inArray(timeEntries.id, ids))
|
||||||
|
|
||||||
|
for (const entry of deletedEntries) {
|
||||||
|
await webhookDispatcher.triggerEvent('time_entry.deleted', entry)
|
||||||
|
}
|
||||||
|
|
||||||
return reply.code(204).send()
|
return reply.code(204).send()
|
||||||
})
|
})
|
||||||
|
|
||||||
fastify.post("/:id/attachments", async (request, reply) => {
|
fastify.post("/:id/attachments", async (request, reply) => {
|
||||||
const { id } = request.params as { id: string }
|
const { id } = request.params as { id: string }
|
||||||
const user = request.user as { sub: string; role: string }
|
|
||||||
const { documentIds } = AttachmentSchema.parse(request.body)
|
const { documentIds } = AttachmentSchema.parse(request.body)
|
||||||
|
const user = request.user as { sub: string; role: string }
|
||||||
|
|
||||||
const [entry] = await db
|
const [entry] = await db
|
||||||
.select()
|
.select()
|
||||||
@ -243,43 +272,16 @@ export default async function timeEntryRoutes(fastify: FastifyInstance) {
|
|||||||
return reply.code(404).send({ message: "Time entry not found" })
|
return reply.code(404).send({ message: "Time entry not found" })
|
||||||
}
|
}
|
||||||
|
|
||||||
const values = documentIds.map(docId => ({
|
await db.delete(timeEntryAttachments).where(eq(timeEntryAttachments.timeEntryId, id))
|
||||||
|
|
||||||
|
const attachments = documentIds.map(docId => ({
|
||||||
timeEntryId: id,
|
timeEntryId: id,
|
||||||
documentId: docId
|
documentId: docId
|
||||||
}))
|
}))
|
||||||
|
|
||||||
await db.insert(timeEntryAttachments).values(values)
|
await db.insert(timeEntryAttachments).values(attachments)
|
||||||
return reply.code(201).send({ message: "Attachments linked" })
|
|
||||||
})
|
|
||||||
|
|
||||||
fastify.delete("/:id/attachments/:docId", async (request, reply) => {
|
await webhookDispatcher.triggerEvent('time_entry.updated', entry)
|
||||||
const { id, docId } = request.params as { id: string; docId: string }
|
return reply.code(200).send({ success: true })
|
||||||
const user = request.user as { sub: string; role: string }
|
|
||||||
|
|
||||||
const [entry] = await db
|
|
||||||
.select()
|
|
||||||
.from(timeEntries)
|
|
||||||
.where(
|
|
||||||
and(
|
|
||||||
eq(timeEntries.id, id),
|
|
||||||
user.role === "admin" ? undefined : eq(timeEntries.userId, user.sub)
|
|
||||||
)
|
|
||||||
)
|
|
||||||
.limit(1)
|
|
||||||
|
|
||||||
if (!entry) {
|
|
||||||
return reply.code(404).send({ message: "Time entry not found" })
|
|
||||||
}
|
|
||||||
|
|
||||||
await db
|
|
||||||
.delete(timeEntryAttachments)
|
|
||||||
.where(
|
|
||||||
and(
|
|
||||||
eq(timeEntryAttachments.timeEntryId, id),
|
|
||||||
eq(timeEntryAttachments.documentId, docId)
|
|
||||||
)
|
|
||||||
)
|
|
||||||
|
|
||||||
return reply.code(204).send()
|
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
45
apps/api/src/services/webhooks.ts
Normal file
45
apps/api/src/services/webhooks.ts
Normal file
@ -0,0 +1,45 @@
|
|||||||
|
import { db } from "../db";
|
||||||
|
import { webhooks } from "../db/schema";
|
||||||
|
import { eq, and } from "drizzle-orm";
|
||||||
|
|
||||||
|
export class WebhookDispatcher {
|
||||||
|
async triggerEvent(event: string, payload: any): Promise<void> {
|
||||||
|
try {
|
||||||
|
const activeWebhooks = await db
|
||||||
|
.select()
|
||||||
|
.from(webhooks)
|
||||||
|
.where(
|
||||||
|
and(
|
||||||
|
eq(webhooks.event, event),
|
||||||
|
eq(webhooks.active, true)
|
||||||
|
)
|
||||||
|
);
|
||||||
|
|
||||||
|
if (activeWebhooks.length === 0) return;
|
||||||
|
|
||||||
|
activeWebhooks.forEach(async (webhook) => {
|
||||||
|
try {
|
||||||
|
const response = await fetch(webhook.url, {
|
||||||
|
method: "POST",
|
||||||
|
headers: { "Content-Type": "application/json" },
|
||||||
|
body: JSON.stringify({
|
||||||
|
event,
|
||||||
|
payload,
|
||||||
|
timestamp: new Date().toISOString(),
|
||||||
|
}),
|
||||||
|
});
|
||||||
|
|
||||||
|
if (!response.ok) {
|
||||||
|
console.error(`Webhook failed for ${webhook.url}: ${response.statusText}`);
|
||||||
|
}
|
||||||
|
} catch (error) {
|
||||||
|
console.error(`Webhook delivery error for ${webhook.url}:`, error);
|
||||||
|
}
|
||||||
|
});
|
||||||
|
} catch (error) {
|
||||||
|
console.error("Error querying webhooks for event:", event, error);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
export const webhookDispatcher = new WebhookDispatcher();
|
||||||
Loading…
Reference in New Issue
Block a user